Skip to content

chore(tests): update gas cost configuration for clz#1887

Merged
spencer-tb merged 1 commit intoethereum:mainfrom
LouisTsai-Csie:fix-clz-gas
Jul 9, 2025
Merged

chore(tests): update gas cost configuration for clz#1887
spencer-tb merged 1 commit intoethereum:mainfrom
LouisTsai-Csie:fix-clz-gas

Conversation

@LouisTsai-Csie
Copy link
Collaborator

@LouisTsai-Csie LouisTsai-Csie commented Jul 9, 2025

🗒️ Description

During the ACDT meeting, we decided to increase the gas cost of CLZ from 3 to 5. This change has been updated in the PR. However, it breaks some existing test cases, which are addressed and fixed in this PR. Additional details are provided below.

🔗 Related Issues or PRs

PR for EEST: #1879
PR for EIP: ethereum/EIPs#9987
PR for EELS: ethereum/execution-specs#1314

Fill with this Osaka in eels_resolutions.json:

    "Osaka": {
        "git_url": "https://github.com/spencer-tb/execution-specs.git",
        "branch": "forks/osaka",
        "commit": "bff77defcfa5be8130cdc6c4ec8200104e22dd8f"
    }

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@LouisTsai-Csie LouisTsai-Csie self-assigned this Jul 9, 2025
@LouisTsai-Csie LouisTsai-Csie added type:refactor Type: Refactor fork:osaka Osaka hardfork labels Jul 9, 2025
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks! Tests all fill now fine for me.
Screenshot 2025-07-09 at 14 34 05

@LouisTsai-Csie LouisTsai-Csie marked this pull request as ready for review July 9, 2025 14:05
@spencer-tb spencer-tb added scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore and removed type:refactor Type: Refactor labels Jul 9, 2025
@spencer-tb spencer-tb changed the title fix(tests): update gas cost configuration for tests chore(tests): update gas cost configuration for clz Jul 9, 2025
@spencer-tb spencer-tb merged commit 73e2d89 into ethereum:main Jul 9, 2025
13 checks passed
kclowes pushed a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork:osaka Osaka hardfork scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants