Skip to content

feat(tests): EIP-7883: triple modexp gas price#1881

Merged
marioevz merged 3 commits intomainfrom
eip-7833-triple
Jul 15, 2025
Merged

feat(tests): EIP-7883: triple modexp gas price#1881
marioevz merged 3 commits intomainfrom
eip-7833-triple

Conversation

@spencer-tb
Copy link
Collaborator

@spencer-tb spencer-tb commented Jul 9, 2025

🗒️ Description

Follows this change to EIP-7883: ethereum/EIPs#9969

EELS PR: ethereum/execution-specs#1318

Fill with this Osaka in eels_resolutions.json:

    "Osaka": {
        "git_url": "https://github.com/spencer-tb/execution-specs.git",
        "branch": "forks/osaka",
        "commit": "bff77defcfa5be8130cdc6c4ec8200104e22dd8f"
    }

🔗 Related Issues or PRs

#1579 #1729 ethereum/execution-specs#1564

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@spencer-tb spencer-tb added scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore fork:osaka Osaka hardfork labels Jul 9, 2025
@spencer-tb spencer-tb changed the title chore(tests): triple modexp gas price. chore(tests): triple modexp gas price Jul 9, 2025
@spencer-tb spencer-tb marked this pull request as ready for review July 9, 2025 12:51
@spencer-tb
Copy link
Collaborator Author

Lets wait for the PR to be merged in EIPs before we merge here.

@spencer-tb spencer-tb requested a review from felix314159 July 10, 2025 08:56
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see one discrepancy with the EIP and had a couple q's 👀

@spencer-tb
Copy link
Collaborator Author

Ready to merge! EIP is also merged in the EIPs repo.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all fills ok with ethereum/execution-specs#1318

@marioevz marioevz changed the title chore(tests): triple modexp gas price feat(tests): EIP-7883: triple modexp gas price Jul 15, 2025
@marioevz marioevz merged commit 485ff27 into main Jul 15, 2025
13 checks passed
@marioevz marioevz deleted the eip-7833-triple branch July 15, 2025 17:38
kclowes pushed a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
* chore(tests): triple modexp gas price.

* chore(tests): update modexp eip-7883 vectors.

* chore(tests): small clarifactions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork:osaka Osaka hardfork scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants