Skip to content

Conversation

@LouisTsai-Csie
Copy link
Collaborator

@LouisTsai-Csie LouisTsai-Csie commented Jun 25, 2025

πŸ—’οΈ Description

Porting benchmark test from Nethermind (Related Link), and this script is used to generate the test cases.

πŸ”— Related Issues

Issue #1734

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@LouisTsai-Csie LouisTsai-Csie self-assigned this Jun 25, 2025
@LouisTsai-Csie LouisTsai-Csie added type:test Type: Add/refactor fw unit tests; no fw or el client test case changes feature:zkevm labels Jun 25, 2025
@LouisTsai-Csie LouisTsai-Csie marked this pull request as ready for review June 25, 2025 13:23
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice one, script is cool.

@spencer-tb spencer-tb merged commit 6aba9a2 into ethereum:main Jun 25, 2025
15 checks passed
Copy link

@marcindsobczak marcindsobczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

exponent="03",
modulus=6 * ("00" + 31 * "FF"),
),
id="mod_min_as_base_heavy",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as -> gas

exponent="07" + 75 * "FF",
modulus=7 * "FF",
),
id="mod_min_as_exp_heavy",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as -> gas

exponent="01" + 3 * "FF",
modulus="00" + 38 * "FF",
),
id="mod_min_as_balanced",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as -> gas

exponent="07" + 6 * "FF",
modulus="00" + 46 * "FF",
),
id="mod_600_as_balanced",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as -> gas

@spencer-tb spencer-tb changed the title test(zkevm): port nethermind modexp benchmark case test(benchmark): port nethermind modexp benchmark case Jul 1, 2025
kclowes pushed a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:benchmark type:test Type: Add/refactor fw unit tests; no fw or el client test case changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants