refactor(fill,deps): forbid yul code in python tests; remove solc-select dependency#1779
Conversation
b4a1242 to
c31efcc
Compare
There was a problem hiding this comment.
Thanks for tackling this @felix314159!
Just a general remark, I prefer smaller PRs and would have preferred if the test refactor from solc to Opcodes was a separate PR. In this case the task list in the issue could have guided you on this path. But we all do it (I'm guilty of it in #1765; I should have done a preliminary refactor PR first).
I think I wasn't aware that the static tests require solc (it's obvious in hindsight, but I thought they only required lllc).
danceratopz
left a comment
There was a problem hiding this comment.
Ups, was trigger happy with the "Submit Review" button and submitted before I was finished. Here's the rest of the review :)
Docs also need to remove all references to solc-select/yul (installation, installation troubleshooting, contributing?).
|
Context on why a coverage fixer test was added: by removing |
danceratopz
left a comment
There was a problem hiding this comment.
Hi Felix, thanks for improving this! I ran out of time before I managed to complete a comprehensive review this morning. But here's some intermediate feedback, will prioritize this on Monday!
danceratopz
left a comment
There was a problem hiding this comment.
Hi @felix314159, continuing on from the reviews above, here's a few more comments. Thanks!
529b1da to
1e46ecf
Compare
|
seems like i messed up this rebase, ill try to revert |
1e46ecf to
afe9adf
Compare
danceratopz
left a comment
There was a problem hiding this comment.
LGTM, thanks for your huge effort on this. And your willingness to go the extra mile to make this PR atomic with updated docs.
One comment on test_coverage_script_fix: I think we can remove this function safely, if you agree, please do that and then we can get this merged!
|
Note: when i run Edit: Next commit fixes this |
a3b7ea1 to
ea9ac45
Compare
danceratopz
left a comment
There was a problem hiding this comment.
Thanks again @felix314159 LGTM!
solc-select dependency
solc-select dependencysolc-select dependency
🗒️ Description
See issue #1759.
🔗 Related Issues
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.