refactor(forks): Make Fork Pydantic-Compatible#1686
Merged
Conversation
9 tasks
danceratopz
approved these changes
Jun 4, 2025
Member
danceratopz
left a comment
There was a problem hiding this comment.
Really nice! Makes so much sense.
I just removed a one-line reference to blockchain_test_network_name in the docs.
Shame we can't quite get rid of the fixture class get_fork() method (due to potentially multi-fork state fixtures). We could apply some pydantic, if we strictly only supported single-fork state test fixtures, but it's nice to be able to maintain the ability to load multi-fork state test fixtures.
kclowes
pushed a commit
to kclowes/execution-spec-tests
that referenced
this pull request
Oct 20, 2025
* refactor(forks): Pydantic-friendly `Fork` type * fix(tests): Bad import * docs(forks): remove `blockchain_test_network_name` from docs --------- Co-authored-by: danceratopz <danceratopz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Modifies
Forktype definition to make it pydantic-friendly, and can now be serialized (into a string) and parsed back into the correct object:instead of:
And the conversion happens on the fly in both directions everywhere.
🔗 Related Issues
None.
✅ Checklist