-
Notifications
You must be signed in to change notification settings - Fork 191
new(tests): add more test cases for request types #1340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+355
β43
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a7d548e
new(tests): added more cases (two contract req, one EOA req) in test_β¦
felix314159 f67fbb2
fixed comments
felix314159 e22fe91
rename test_deposits_withdrawals_consolidations.py to test_multi_typeβ¦
felix314159 4310e6c
changed type from ParameterSet to a union of the three request types,β¦
felix314159 fb157d6
added draft test of trying out a modified withdrawal contract that alβ¦
felix314159 4c48495
fixed docstrings
felix314159 c0f885d
tried to implement marios feedback
felix314159 b61fe3e
moved test to a better suited folder (eip7002)
felix314159 d2519c4
parameterized test and bugfixes
felix314159 e9a5740
added pseudo contract that just returns withdrawals requests
felix314159 c1e9fc9
removed unnecessary offset update
felix314159 85ac1ff
macro MSTORE now used instead of manually splitting into chunks
felix314159 1d5b358
Update tests/prague/eip7002_el_triggerable_withdrawals/test_modified_β¦
marioevz 0ceffe2
Datatype is ParameterSet
felix314159 10f41b0
added pytest marker for prague, and some minor fixes
felix314159 8c3adbd
removed comment and updated CHANGELOG.md
felix314159 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
206 changes: 206 additions & 0 deletions
206
tests/prague/eip7002_el_triggerable_withdrawals/test_modified_withdrawal_contract.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,206 @@ | ||
| """ | ||
| abstract: Tests [EIP-7002: Execution layer triggerable withdrawals](https://eips.ethereum.org/EIPS/eip-7002) | ||
| Test execution layer triggered exits [EIP-7002: Execution layer triggerable withdrawals](https://eips.ethereum.org/EIPS/eip-7002). | ||
|
|
||
| """ # noqa: E501 | ||
|
|
||
| from typing import List | ||
|
|
||
| import pytest | ||
|
|
||
| from ethereum_test_tools import ( | ||
| Account, | ||
| Alloc, | ||
| Block, | ||
| BlockchainTestFiller, | ||
| Bytecode, | ||
| Transaction, | ||
| ) | ||
| from ethereum_test_tools import Macros as Om | ||
| from ethereum_test_tools import Opcodes as Op | ||
| from ethereum_test_types import Requests | ||
|
|
||
| from .helpers import ( | ||
| WithdrawalRequest, | ||
| # WithdrawalRequestBase, | ||
| # WithdrawalRequestContract, | ||
| WithdrawalRequestTransaction, | ||
| ) | ||
| from .spec import Spec as Spec_EIP7002 | ||
| from .spec import ref_spec_7002 | ||
|
|
||
| REFERENCE_SPEC_GIT_PATH: str = ref_spec_7002.git_path | ||
| REFERENCE_SPEC_VERSION: str = ref_spec_7002.version | ||
|
|
||
| pytestmark: pytest.MarkDecorator = pytest.mark.valid_from("Prague") | ||
|
|
||
|
|
||
marioevz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| def withdrawal_list_with_custom_fee(n: int) -> List[WithdrawalRequest]: # noqa: D103 | ||
| return [ | ||
| WithdrawalRequest( | ||
| validator_pubkey=i + 1, | ||
| amount=0, | ||
| fee=Spec_EIP7002.get_fee(0), | ||
| ) | ||
| for i in range(n) | ||
| ] | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "requests_list", | ||
| [ | ||
| pytest.param( | ||
| [], | ||
| id="empty_request_list", | ||
| ), | ||
| pytest.param( | ||
| [ | ||
| *withdrawal_list_with_custom_fee(1), | ||
| ], | ||
| id="1_withdrawal_request", | ||
| ), | ||
| pytest.param( | ||
| [ | ||
| *withdrawal_list_with_custom_fee(15), | ||
| ], | ||
| id="15_withdrawal_requests", | ||
| ), | ||
| pytest.param( | ||
| [ | ||
| *withdrawal_list_with_custom_fee(16), | ||
| ], | ||
| id="16_withdrawal_requests", | ||
| ), | ||
| pytest.param( | ||
| [ | ||
| *withdrawal_list_with_custom_fee(17), | ||
| ], | ||
| id="17_withdrawal_requests", | ||
| ), | ||
| pytest.param( | ||
| [ | ||
| *withdrawal_list_with_custom_fee(18), | ||
| ], | ||
| id="18_withdrawal_requests", | ||
| ), | ||
| ], | ||
| ) | ||
| def test_extra_withdrawals( | ||
| blockchain_test: BlockchainTestFiller, | ||
| pre: Alloc, | ||
| requests_list: List[WithdrawalRequest], | ||
| ): | ||
| """Test how clients were to behave when more than 16 withdrawals (here: 18 withdrawals) would be allowed per block.""" # noqa: E501 | ||
| # Source of code (change value of this line to 18 and re-compile with fjl/geas): https://github.com/lightclient/sys-asm/blob/f1c13e285b6aeef2b19793995e00861bf0f32c9a/src/withdrawals/main.eas#L37 # noqa: E501, W291 | ||
| modified_code: bytes = b"3373fffffffffffffffffffffffffffffffffffffffe1460cb5760115f54807fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff146101f457600182026001905f5b5f82111560685781019083028483029004916001019190604d565b909390049250505036603814608857366101f457346101f4575f5260205ff35b34106101f457600154600101600155600354806003026004013381556001015f35815560010160203590553360601b5f5260385f601437604c5fa0600101600355005b6003546002548082038060121160df575060125b5f5b8181146101835782810160030260040181604c02815460601b8152601401816001015481526020019060020154807fffffffffffffffffffffffffffffffff00000000000000000000000000000000168252906010019060401c908160381c81600701538160301c81600601538160281c81600501538160201c81600401538160181c81600301538160101c81600201538160081c81600101535360010160e1565b910180921461019557906002556101a0565b90505f6002555f6003555b5f54807fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff14156101cd57505f5b6001546002828201116101e25750505f6101e8565b01600290035b5f555f600155604c025ff35b5f5ffd" # noqa: E501 | ||
marioevz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| pre[Spec_EIP7002.WITHDRAWAL_REQUEST_PREDEPLOY_ADDRESS] = Account( | ||
| code=modified_code, | ||
| nonce=1, | ||
| balance=0, | ||
| ) | ||
|
|
||
| # given a list of withdrawal requests construct a withdrawal request transaction | ||
| withdrawal_request_transaction = WithdrawalRequestTransaction(requests=requests_list) | ||
| # prepare withdrawal senders | ||
| withdrawal_request_transaction.update_pre(pre=pre) | ||
| # get transaction list | ||
| txs: List[Transaction] = withdrawal_request_transaction.transactions() | ||
|
|
||
| blockchain_test( | ||
| pre=pre, | ||
| blocks=[ | ||
| Block( | ||
| txs=txs, | ||
| requests_hash=Requests(*requests_list), | ||
| ), | ||
| ], | ||
| post={}, | ||
| ) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "requests_list", | ||
| [ | ||
| pytest.param( | ||
| [], | ||
| id="empty_request_list", | ||
| ), | ||
| pytest.param( | ||
| [ | ||
| *withdrawal_list_with_custom_fee(1), | ||
| ], | ||
| id="1_withdrawal_request", | ||
| ), | ||
| pytest.param( | ||
| [ | ||
| *withdrawal_list_with_custom_fee(15), | ||
| ], | ||
| id="15_withdrawal_requests", | ||
| ), | ||
| pytest.param( | ||
| [ | ||
| *withdrawal_list_with_custom_fee(16), | ||
| ], | ||
| id="16_withdrawal_requests", | ||
| ), | ||
| pytest.param( | ||
| [ | ||
| *withdrawal_list_with_custom_fee(17), | ||
| ], | ||
| id="17_withdrawal_requests", | ||
| ), | ||
| pytest.param( | ||
| [ | ||
| *withdrawal_list_with_custom_fee(18), | ||
| ], | ||
| id="18_withdrawal_requests", | ||
| ), | ||
| ], | ||
| ) | ||
| def test_extra_withdrawals_pseudo_contract( | ||
| blockchain_test: BlockchainTestFiller, | ||
| pre: Alloc, | ||
| requests_list: List[WithdrawalRequest], | ||
| ): | ||
| """Test how clients were to behave when more than 16 withdrawals would be allowed per block.""" | ||
| modified_code: Bytecode = Bytecode() | ||
| memory_offset: int = 0 | ||
| amount_of_requests: int = 0 | ||
|
|
||
| for withdrawal_request in requests_list: | ||
| # update memory_offset with the correct value | ||
| withdrawal_request_bytes_amount: int = len(bytes(withdrawal_request)) | ||
| assert withdrawal_request_bytes_amount == 76, ( | ||
| "Expected withdrawal request to be of size 76 but got size " | ||
| f"{withdrawal_request_bytes_amount}" | ||
| ) | ||
| memory_offset += withdrawal_request_bytes_amount | ||
|
|
||
| modified_code += Om.MSTORE(bytes(withdrawal_request), memory_offset) | ||
| amount_of_requests += 1 | ||
|
|
||
| modified_code += Op.RETURN(0, Op.MSIZE()) | ||
|
|
||
| pre[Spec_EIP7002.WITHDRAWAL_REQUEST_PREDEPLOY_ADDRESS] = Account( | ||
| code=modified_code, | ||
| nonce=1, | ||
| balance=0, | ||
| ) | ||
|
|
||
| # given a list of withdrawal requests construct a withdrawal request transaction | ||
| withdrawal_request_transaction = WithdrawalRequestTransaction(requests=requests_list) | ||
| # prepare withdrawal senders | ||
| withdrawal_request_transaction.update_pre(pre=pre) | ||
| # get transaction list | ||
| txs: List[Transaction] = withdrawal_request_transaction.transactions() | ||
marioevz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| blockchain_test( | ||
| pre=pre, | ||
| blocks=[ | ||
| Block( | ||
| txs=txs, | ||
| requests_hash=Requests(*requests_list), | ||
| ), | ||
| ], | ||
| post={}, | ||
| ) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.