feat(fill): also test system contract deployments with balance#1132
Merged
feat(fill): also test system contract deployments with balance#1132
Conversation
danceratopz
added
type:feat
marioevz
approved these changes
Jan 27, 2025
Member
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
LGTM. Verified the generated fixtures after the change and it look good, thanks!
marioevz
pushed a commit
to marioevz/execution-spec-tests
that referenced
this pull request
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR modifies the
@generate_system_contract_deploy_testdecorator to additionally generate tests for the case when the target contract address has a non-zero balance prior to deployment.This adds additional tests for EIP-7002, EIP-2935 and EIP-7251.
Initial suggestion from @jochem-brouwer in #el-testing.
🔗 Related Issues
#1024, the PR where the system test contract generator was added.
✅ Checklist
All: Added an entry to CHANGELOG.md.skipped