[eth_getTransactionByHash] Update blob tx response to match the spec #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I have re-added these fields to the spec in #575 |
Contributor
|
We need to keep supporting them because some RPC clients rely on these fields. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blob tx response in spec excludes
gasPriceandvkeys, while the tests (which as I understood are generated vialightclient/rpctestgenthat uses geth under the hood(?)).While this PR won't fix the underlying problem (using implementation for testgen) at least it would "fix" the hive test.
Note:
The diff is bad, so something like this might be helpful for verification: https://jsondiff.com/