Clarify Cancun payloads handling by earlier APIs; reorder checks#426
Merged
mkalinin merged 7 commits intoethereum:mainfrom Aug 4, 2023
Merged
Clarify Cancun payloads handling by earlier APIs; reorder checks#426mkalinin merged 7 commits intoethereum:mainfrom
mkalinin merged 7 commits intoethereum:mainfrom
Conversation
Contributor
flcl42
commented
Jun 29, 2023
flcl42
commented
- Remove uncertainty in handling Cancun payload by previous forks' APIs
- Remove redundant spec
- Clarify the order of overlapping payload verification rules
flcl42
changed the title
mkalinin
reviewed
Jun 29, 2023
mkalinin
reviewed
Jul 3, 2023
flcl42
force-pushed
the
clarify-payload-api-checks
branch
from
f0f5ba7 to
55c1b63
Compare
flcl42
force-pushed
the
clarify-payload-api-checks
branch
from
c44d38e to
8a0ef17
Compare
LukaszRozmej
approved these changes
Jul 10, 2023
MarekM25
approved these changes
Jul 10, 2023
8 tasks
g11tech
approved these changes
Jul 10, 2023
yperbasis
approved these changes
Aug 3, 2023
jflo
approved these changes
Aug 3, 2023
flcl42
force-pushed
the
clarify-payload-api-checks
branch
from
1ce7366 to
806e44d
Compare
flcl42
force-pushed
the
clarify-payload-api-checks
branch
from
806e44d to
292f5be
Compare
jochem-brouwer
approved these changes
Aug 3, 2023
Member
jochem-brouwer
left a comment
jochem-brouwer
left a comment
There was a problem hiding this comment.
Love the change to first do input checks, then the timestamp check. LGTM!
marioevz
approved these changes
Aug 3, 2023
g11tech
reviewed
Aug 3, 2023
| This method follows the same specification as [`engine_newPayloadV2`](./shanghai.md#engine_newpayloadv2) with the addition of the following: | ||
|
|
||
| 1. Given the expected array of blob versioned hashes client software **MUST** run its validation by taking the following steps: | ||
| 1. Client software **MUST** check that provided set of parameters and their fields strictly matches the expected one and return `-32602: Invalid params` error if this check fails. Any field having `null` value **MUST** be considered as not provided. |
Contributor
There was a problem hiding this comment.
+1 for first checking correct fields before timestamp
g11tech
reviewed
Aug 3, 2023
Co-authored-by: g11tech <develop@g11tech.io>
flcl42
force-pushed
the
clarify-payload-api-checks
branch
from
32259b5 to
ad2ccb0
Compare
mkalinin
approved these changes
Aug 4, 2023
yperbasis
added a commit
to erigontech/erigon
that referenced
this pull request
Aug 6, 2023
…88) (#7969) Prerequisites: erigontech/interfaces#187 & ledgerwatch/erigon-lib#1069. Also implement ethereum/execution-apis#426.
AskAlexSharov
pushed a commit
to erigontech/erigon
that referenced
this pull request
Sep 6, 2023
…88) (#7969) Prerequisites: erigontech/interfaces#187 & ledgerwatch/erigon-lib#1069. Also implement ethereum/execution-apis#426.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.