graphql: add withdrawals (EIP-4895)#400
Merged
lightclient merged 5 commits intoethereum:mainfrom May 30, 2023
Merged
Conversation
Contributor
|
@shemnon please check this! |
Contributor
|
@jangko, too |
s1na
force-pushed
the
graphql/withdrawals
branch
from
e05e067 to
1c6d6ce
Compare
Contributor
|
Ping, let's get this merged. |
Contributor
Author
|
Besu merged support for withdrawals matching the spec here. I think we can move forward. |
lightclient
reviewed
May 30, 2023
Member
lightclient
left a comment
lightclient
left a comment
There was a problem hiding this comment.
just a couple comment nits, otherwise looks good
schema.graphqls
Outdated
| raw: Bytes! | ||
|
|
||
| """ | ||
| WithdrawalsRoot is the keccak256 hash of the root of the trie of withdrawals in this block. |
Member
There was a problem hiding this comment.
Suggested change
| WithdrawalsRoot is the keccak256 hash of the root of the trie of withdrawals in this block. | |
| WithdrawalsRoot is the keccak256 hash of the root of the trie of withdrawals in this block. |
same here
Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>
lightclient
reviewed
May 30, 2023
lightclient
approved these changes
May 30, 2023
holiman
pushed a commit
to ethereum/go-ethereum
that referenced
this pull request
Jun 6, 2023
implements withdrawals in graphql as per ethereum/execution-apis#400
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
implements withdrawals in graphql as per ethereum/execution-apis#400
cyyber
pushed a commit
to cyyber/go-zond
that referenced
this pull request
Nov 27, 2023
implements withdrawals in graphql as per ethereum/execution-apis#400
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Geth implementation: ethereum/go-ethereum#27072
Hive tests: ethereum/hive#764