Extend EIP-4844 to include withdrawals #322
Conversation
src/engine/blob-extension.md
Outdated
| @@ -5,6 +5,27 @@ This extension is backwards-compatible, but not part of the initial Engine API. | |||
|
|
|||
| ## Structures | |||
|
|
|||
| ### ExecutionPayloadV2 | |||
There was a problem hiding this comment.
how does this interact w/ the existing ExecutionPayloadV2?
is this extension an alternative fork of the spec?
or should this be a V3 to include the excessDataGas field?
There was a problem hiding this comment.
it's an alternative fork where withdrawals and 4844 are part of the same upgrade.
There was a problem hiding this comment.
so we reuse the existing v2 apis rather than create another one
There was a problem hiding this comment.
likely worth adding a note to this effect in this document
There was a problem hiding this comment.
This is already noted here in the document. I can edit it if the wording isn't clear enough.
There was a problem hiding this comment.
I've added more wording to clarify this, including adding V2 API methods to this spec.
There was a problem hiding this comment.
it's an alternative fork where withdrawals and 4844 are part of the same upgrade.
This is different than the consensus spec. The consensus spec is treating them as different forks that are going from bellatrix -> capella -> eip4844. If we implement engine API as it is, then the Capella block processing will fail
There was a problem hiding this comment.
So I think this should be V3
|
@ralexstokes any further comments? |
|
I think as long as implementers know what is going on here then this is fine -- we will need to update this in the long run however as we can't have two different v2's |
|
@lightclient updated the method and type names to |
Updates the EIP-4844 spec extension to include withdrawals. The ExecutionPayloadV2 header is updated to do this. As with #197, this change isn't part of the core spec.