-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for topic when parsing deposit contract logs #1152
Conversation
1740931
to
14f4a2b
Compare
LGTM. This is how all the other clients approach it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a regression test for this?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1152 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 168 168
Lines 18246 18256 +10
=======================================
+ Hits 17251 17261 +10
Misses 995 995
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase on top of #1159 and add a regression test.
14f4a2b
to
e9ba681
Compare
Turns out on Sepolia deposit contract is different and can emit other logs (ERC20's
Transfer
)