eof: Remove duplicated type section size check #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check that type section size matches the number of code sections is done twice in EOF validation: - in `validate_section_headers()` - in `validate_header()` which always calls `validate_section_headers()` so this check never fails. I decided to leave the check in `validate_header()` because it better fits there.
chfast
force-pushed
the
eof/duplicated_type_section_size_check
branch
from
1e500d7 to
466fb42
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1137 +/- ##
=======================================
Coverage 94.50% 94.50%
=======================================
Files 167 167
Lines 18202 18199 -3
=======================================
- Hits 17201 17199 -2
+ Misses 1001 1000 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pdobacz
approved these changes
Feb 20, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check that type section size matches the number of code sections is done twice in EOF validation:
validate_section_headers()validate_header()which always callsvalidate_section_headers()so this check never fails.I decided to leave the check in
validate_header()because it better fits there.