EIP-6110: Supply validator deposits on chain #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1079 +/- ##
=======================================
Coverage 94.29% 94.29%
=======================================
Files 159 159
Lines 17095 17114 +19
=======================================
+ Hits 16120 16138 +18
- Misses 975 976 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
force-pushed
the
eip-6110
branch
13 times, most recently
from
c839965 to
1ab64f4
Compare
gumb0
force-pushed
the
eip-6110
branch
4 times, most recently
from
d8edd6d to
8c53136
Compare
gumb0
force-pushed
the
eip-6110
branch
2 times, most recently
from
ffd169f to
a364927
Compare
gumb0
force-pushed
the
eip-6110
branch
2 times, most recently
from
371a7b3 to
e226cb0
Compare
gumb0
force-pushed
the
eip-6110
branch
2 times, most recently
from
7cbe30d to
4370a98
Compare
gumb0
force-pushed
the
eip-6110
branch
2 times, most recently
from
6712475 to
c04a3fe
Compare
gumb0
commented
Dec 12, 2024
| @@ -37,9 +38,15 @@ struct Requests | |||
| Type type = Type::deposit; | |||
| /// Requests data - an opaque byte array, contains zero or more encoded request objects. | |||
| evmc::bytes data; | |||
|
|
|||
| explicit Requests(Type _type, evmc::bytes _data = {}) noexcept | |||
There was a problem hiding this comment.
Needed to make vector::emplace_back() work for this struct on some compilers.
There was a problem hiding this comment.
I use other workaround: emplace_back(Requests{...}). I wonder which pattern is easier to find later...
There was a problem hiding this comment.
Usually me too, but this time I think I got error from clang-tidy "unnecessary temporary object created"
There was a problem hiding this comment.
Copilot reviewed 1 out of 5 changed files in this pull request and generated no suggestions.
Files not reviewed (4)
- test/blockchaintest/blockchaintest_runner.cpp: Language not supported
- test/state/requests.cpp: Language not supported
- test/state/requests.hpp: Language not supported
- test/t8n/t8n.cpp: Language not supported
chfast
reviewed
Dec 13, 2024
chfast
approved these changes
Dec 13, 2024
pdobacz
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eips.ethereum.org/EIPS/eip-6110