Move code reference to message #705
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
code_in_msg
branch
3 times, most recently
from
c3499c2
to
a1df1d1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #705 +/- ##
=======================================
Coverage 93.49% 93.50%
=======================================
Files 25 25
Lines 3861 3865 +4
Branches 396 396
=======================================
+ Hits 3610 3614 +4
Misses 139 139
Partials 112 112 |
gumb0
reviewed
Mar 14, 2024
| @@ -745,13 +739,9 @@ class VM | |||
| /// but without providing the Host context and interface. | |||
gumb0
reviewed
Mar 14, 2024
| ) -> ::evmc_vm::ffi::evmc_result | ||
| { | ||
| use evmc_vm::EvmcVm; | ||
|
|
||
| // TODO: context is optional in case of the "precompiles" capability |
There was a problem hiding this comment.
I wasn't able to translate the check easily and also not sure if this check isn't to heavy to be included in the bindings (unless this helps Rust translation somehow).
There was a problem hiding this comment.
Maybe TODO is worth to leave? It seems to point to something that is not yet implemented in bindings, but might be useful.
There was a problem hiding this comment.
I don't think the check for instance/msg null should be removed. This is the place it ensures it won't be null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.