hex: Add from_hex<T> for user types #649
Conversation
chfast
force-pushed
the
hex_to_T
branch
2 times, most recently
from
98570a9
to
a66d6d5
Compare
include/evmc/hex.hpp
Outdated
|
|
||
| /// Decodes hex-encoded string into custom type T with .bytes array of uint8_t. | ||
| /// | ||
| /// The decoded bytes are right aligned in case the input is smaller than the result type. |
There was a problem hiding this comment.
Because they imitate BE numbers.
There was a problem hiding this comment.
So by right aligned do you mean padded with zeroes on the left?
There was a problem hiding this comment.
Yes, but left/right does not have clear meaning.
There was a problem hiding this comment.
When the input is smaller than the result type, the result is padded with zeros on the left (the result bytes of lowest indices are filled with zeros).
?
There was a problem hiding this comment.
Can we add a flag for alignment?
Coming from Solidity would prefer left aligned if we are writing into a "bytes" type. But this opinion is not too strong if you only have use cases for right aligned.
There was a problem hiding this comment.
Yes, an option can be added if needed, but so far this is only used for literals and loading storage values from JSON.
There was a problem hiding this comment.
Perhaps add // TODO: support left alignment too with a flag.
chfast
force-pushed
the
hex_refactor
branch
2 times, most recently
from
4048132
to
508475b
Compare
chfast
force-pushed
the
hex_refactor
branch
4 times, most recently
from
c0337b9
to
5cec7bd
Compare
Codecov Report
@@ Coverage Diff @@
## master #649 +/- ##
=======================================
Coverage 92.99% 92.99%
=======================================
Files 25 25
Lines 3626 3626
Branches 377 377
=======================================
Hits 3372 3372
Misses 144 144
Partials 110 110 |
chfast
force-pushed
the
hex_to_T
branch
3 times, most recently
from
9471c85
to
95805a2
Compare
Depends on #648.