java: Use allocateDirect instead of wrap in copy_code #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
approved these changes
Sep 27, 2020
This is important, because wrap would use the underlying returned buffer, while the EVMC interface specifically states it must be copied.
axic
force-pushed
the
use_direct_buffer
branch
from
f012549
to
953e640
Compare
axic
changed the title
axic
approved these changes
Sep 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peeling off a change from #532 to single it out. This fixes a bug in how Java interfaces with JNI. JNI requires a direct buffer allocation instead of a heap bytebuffer.