Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: upgrade bindgen to 0.54 #526

Merged
merged 1 commit into from
Jun 24, 2020
Merged

rust: upgrade bindgen to 0.54 #526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindings/rust/evmc-sys/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ categories = ["external-ffi-bindings"]
edition = "2018"

[build-dependencies]
bindgen = "0.52.0"
bindgen = "0.54.0"
2 changes: 2 additions & 0 deletions bindings/rust/evmc-sys/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ fn gen_bindings() {
.whitelist_type("evmc_.*")
.whitelist_function("evmc_.*")
.whitelist_var("EVMC_ABI_VERSION")
// TODO: consider removing this
.size_t_is_usize(true)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the default <0.52.0 and our bindings rely on this. It was disabled by default in 0.53.0 but this option exists in 0.54.0.

We have to consider changing the bindings, but this update here with this setting will produce identical output so no risk.

.generate()
.expect("Unable to generate bindings");

Expand Down