Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return bool from some Host methods #140

Merged
merged 4 commits into from
Sep 6, 2018
Merged

Return bool from some Host methods #140

merged 4 commits into from
Sep 6, 2018

Conversation

chfast
Copy link
Member

@chfast chfast commented Sep 6, 2018 •
edited
Loading

Resolves #117

@chfast chfast requested a review from axic September 6, 2018 08:24
@axic
Copy link
Member

axic commented Sep 6, 2018

It looks good to me.

@chfast chfast force-pushed the bool-return-type branch 2 times, most recently from e38c9ed to 553db64 Compare September 6, 2018 10:20
@axic
Copy link
Member

axic commented Sep 6, 2018

Return bool from evmc_gen_balance_fn()

->

Return bool from evmc_get_balance_fn()

axic
axic approved these changes Sep 6, 2018
View reviewed changes
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the single typo.

@chfast chfast merged commit 735e5ec into master Sep 6, 2018
@chfast chfast deleted the bool-return-type branch September 6, 2018 12:40
@chfast chfast mentioned this pull request Oct 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfast @axic