Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host interface #125

Merged
merged 1 commit into from
Aug 31, 2018
Merged

Host interface #125

merged 1 commit into from
Aug 31, 2018

Conversation

chfast
Copy link
Member

@chfast chfast commented Aug 31, 2018 •
edited by axic
Loading

Closes #105.

@axic
Copy link
Member

axic commented Aug 31, 2018

I did the same change and assigned the issue yesterday to me. So what is the process then? Aren't assigning issues marks it as taken? :)

@chfast
Copy link
Member Author

chfast commented Aug 31, 2018

Sorry, I have not seen it.

axic
axic approved these changes Aug 31, 2018
View reviewed changes
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The renaming of context looks ok.

@chfast chfast merged commit 4d86207 into master Aug 31, 2018
@chfast chfast deleted the host-interface branch August 31, 2018 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axic axic axic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfast @axic