Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

few optimizations on pruning #1278

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

few optimizations on pruning #1278

wants to merge 1 commit into from

Conversation

AbdelStark
Copy link

  • add final modifier when appropriate for method parameters
  • add final modifier when appropriate for class fields
  • add final modifier when appropriate for class
  • optimize HashUtil.shortHash()
  • use forEach instead of loop to have more consistency in the class

@AbdelStark
few optimizations on pruning
dd70362 
- add final modifier when appropriate for method parameters
- add final modifier when appropriate for class fields
- add final modifier when appropriate for class
- optimize `HashUtil.shortHash()`
- use `forEach` instead of loop to have more consistency in the class
@AbdelStark
Copy link
Author

@mkalinin can you review it please ?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 57.674% when pulling dd70362 on abdelhamidbakhta:feature/pruning into 7a816c1 on ethereum:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbdelStark @coveralls