-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added reference to a page collecting numerous security recommendations #91
Conversation
docs/developers/index.md
Outdated
@@ -206,6 +206,7 @@ The Ethereum network is made up of many nodes who run compatible client software | |||
|
|||
### Looking for other options? | |||
- [Ethereum Developer Tools List #Patterns—best-practices](https://github.com/ConsenSys/ethereum-developer-tools-list#patterns--best-practices) | |||
- [Aggregated collection of security recommendations and best practices (Updated on 21-5-2019)](https://github.com/guylando/KnowledgeLists/blob/master/EthereumSmartContracts.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the other links have a time stamp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, why not put this into the Smart Contract Security Best Practices Guide
subsection?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Well as I wrote in the pull message above, I think it is important to let people be aware in case they are reading old information. During my research I have been reading too much things which turned out to be irrelevant after solidity 0.5.0 changes.
- Where else to put it? That is exactly what the link includes in my opinion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, your github repo should contain a date, but would you update this repo every time you make a change?
You put into the subsection Looking for other options?
. I propose to instead move it up one subsection into Smart Contract Security Best Practices Guide
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I was looking at it from another perspective of letting people know that this information is fresh as of may 2019 compared to some of the others but maybe it ruins more than it helps because of what you said. Will remove the timestamp.
Will Do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Please squash! Fine otherwise. |
…s and best practices
@chriseth done |
Not sure if I should merge here, but I'll just try. |
Update 7.23.0
The new resource was freshly created this week while most if not all of other resources are outdated.
@chriseth can you merge this?