Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reference to a page collecting numerous security recommendations #91

Merged
merged 1 commit into from
May 27, 2019

Conversation

guylando
Copy link
Contributor

The new resource was freshly created this week while most if not all of other resources are outdated.
@chriseth can you merge this?

@@ -206,6 +206,7 @@ The Ethereum network is made up of many nodes who run compatible client software

### Looking for other options?
- [Ethereum Developer Tools List #Patterns—best-practices](https://github.com/ConsenSys/ethereum-developer-tools-list#patterns--best-practices)
- [Aggregated collection of security recommendations and best practices (Updated on 21-5-2019)](https://github.com/guylando/KnowledgeLists/blob/master/EthereumSmartContracts.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the other links have a time stamp?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, why not put this into the Smart Contract Security Best Practices Guide subsection?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Well as I wrote in the pull message above, I think it is important to let people be aware in case they are reading old information. During my research I have been reading too much things which turned out to be irrelevant after solidity 0.5.0 changes.
  2. Where else to put it? That is exactly what the link includes in my opinion

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, your github repo should contain a date, but would you update this repo every time you make a change?

You put into the subsection Looking for other options?. I propose to instead move it up one subsection into Smart Contract Security Best Practices Guide .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I was looking at it from another perspective of letting people know that this information is fresh as of may 2019 compared to some of the others but maybe it ruins more than it helps because of what you said. Will remove the timestamp.

Will Do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@chriseth
Copy link
Contributor

Please squash! Fine otherwise.

@guylando
Copy link
Contributor Author

@chriseth done

@chriseth
Copy link
Contributor

Not sure if I should merge here, but I'll just try.

@chriseth chriseth merged commit 7b77638 into ethereum:master May 27, 2019
@F153 F153 mentioned this pull request Mar 19, 2023
TylerAPfledderer pushed a commit to TylerAPfledderer/ethereum-org-website that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants