Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix firefox page padding [fixes #833] #842

Merged
merged 4 commits into from
Mar 20, 2020

Conversation

carlfairclough
Copy link
Contributor

@carlfairclough carlfairclough commented Mar 18, 2020

This provides a fallback for browsers which do not read min() max() css funtions.

Description

A stylus function has been created which will allow for linear scaling between two values.

34px @ 320px viewport → 72px @ 768px viewport
cssGrad(320, 34, 768, 72)

This function must be followed by a media query at the upper and lower limits, to prevent runaway scaling:

.el
  width cssGrad(320, 34, 768, 72)
  @media screen and (min-width: 768px)
    width: 72px

A fixed-px fallback has been added for the list blank states, as that was previously using min().

Related Issue

#833

Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlfairclough I'm still seeing this issue of Firefox,

  1. When I make my browser slightly smaller (but still have sidebar)

Image 2020-03-19 at 10 20 46 AM

  1. When the browser window is small enough that the sidebar disappears (e.g. on iPad):

Image 2020-03-19 at 10 21 12 AM

Please make the needed updates & confirm these are addressed.

@carlfairclough
Copy link
Contributor Author

@samajammin This doesn't happen when in dev so I'm assuming it's a part of the stylus build process, perhaps ensuring that there is only one of each property per class?

I've admitted defeat — this is using media queries now

@samajammin samajammin merged commit 3fca08e into ethereum:dev Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants