-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lists [fixes #767] #839
Lists [fixes #767] #839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content '↗️' | ||
|
||
.list-new | ||
box-shadow 0px 14px 66px rgba(0, 0, 0, 0.07), 0px 10px 17px rgba(0, 0, 0, 0.03), 0px 4px 7px rgba(0, 0, 0, 0.05) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note - if we use these same shadows elsewhere (e.g. in Card components), we should consider setting these as variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'll leave this here for now but I'm considering updating the card component to allow children, at which point I'll be able to remove this
This isn't an issue with the cards, it's an issue with the |
@samajammin all changes made apart from a couple. Added comments ☝️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Groovy 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samajammin done! Not perfect (wide click target) but working |
Added lists removed file removed duplicate rows
Removed list line-breaks Removed internal prop, using utils.js removed list-link-description add target & rel props to external link items Updated item title
Added lists & documentation for them Implemented simple list on
/developers
pageDescription
Added multiple list variations based on the Figma Style Guide. These include lists with descriptions, and list cards in multiple layouts.
An array of objects should be passed to leverage the card format, and a class should be added to the standard lists to enable their modification.
Screenshots (if appropriate):