Update EIP-1559 label to "Fee optimization" for find-wallet #7319
Conversation
corwintines
requested review from
samajammin,
wackerow,
pettinarip,
minimalsm and
jmcook1186
as code owners
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 27m |
| description: "Lower gas fees with type-2 transactions", | ||
| title: "Fee optimization", | ||
| description: | ||
| "Support type 2 transactions for optimized gas fees, and fee refunds for unused gas", |
There was a problem hiding this comment.
Questions (that could be solved in a separate PR):
- Would it still be illuminating/valuable to mention EIP 1559 anywhere?
- Do we define "type 2 transactions" anywhere? If not we probably should... e.g. on the tx page: https://ethereum.org/en/developers/docs/transactions/#typed-transaction-envelope
There was a problem hiding this comment.
Created an issue around the 2nd point: #7372
There was a problem hiding this comment.
I think we could add something to the description for this. I was going to do a general pass over the copy for these next sprint so I think it could be done then.
| @@ -131,8 +131,9 @@ const walletFilterData: { [key: string]: WalletFilter } = { | |||
| filterKey: "erc_20_support", | |||
| }, | |||
| eip_1559_support: { | |||
There was a problem hiding this comment.
If we remove mention of EIP 1559, should we update this eip_1559_support key, e.g. to type_2_tx_support?
There was a problem hiding this comment.
Been looking at this code again and I think there should be a refactor on the filters to clean the code up there. I think for myself keeping it as eip_1559_support helps as it is clear what it is as a variable, but open to suggestions.
Description
EIP-1559 supporttoFee optimization