Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding etherlime in the frameworks section #45

Merged
merged 2 commits into from
May 10, 2019

Conversation

Perseverance
Copy link
Contributor

No description provided.

@jjmstark jjmstark requested a review from maurelian May 9, 2019 16:09
Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the new content to the end of the section.

@@ -57,6 +57,10 @@ Ethereum has a large and growing number of tools to help developers build, test,
- [Github](https://github.com/embark-framework/embark)
- [Documentation](https://embark.status.im/docs/)

### Etherlime *Ethers.js based framework for dapp development (Solidity & Vyper), deployment, debugging, testing and more.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be easier to merge if it weren't arbitarily placed above another item which is already included.

I'm not favoring waffle, as I've used neither. I just want to default to 'first come first served' without other strong arguments to go on.

Copy link
Contributor Author

@Perseverance Perseverance May 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've no particular preference where to put it, I've put it there for chronological reason, but if you want to default to FIFO I am fine to move it downwards

Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maurelian maurelian merged commit 93f66d7 into ethereum:master May 10, 2019
TylerAPfledderer pushed a commit to TylerAPfledderer/ethereum-org-website that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants