Add batching to Github API requests #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samajammin
requested review from
GeorgeTrotter,
jjmstark and
ryancreatescopy
as code owners
github-actions
bot
added
dependencies 📦
|
@wackerow @ryancreatescopy I think I finally got this working 😵 Mind checking this branch out locally & seeing if things work for you?
Does anything break!? |
samajammin
changed the title
Closed
samajammin
changed the title
samajammin
force-pushed
the
gatsby-source-graphql-fixes
branch
from
849d1e9 to
1dcfe52
Compare
This was referenced Jan 23, 2021
wackerow
approved these changes
Jan 23, 2021
|
Second time it built without the errors but still lots of warnings about missing custom ID on headers etc... |
|
Same for the thrice time 👍 |
|
Groovy! Seems this is working given all builds appear to work. I'm going to merge this. @ryancreatescopy re: those .gif errors - I received the same thing originally. Mind running a |
This was referenced Feb 2, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Batch GraphQL requests (10 at a time) to Github API to avoid rate limits & broken builds ☠️
Context for the curious:
https://www.gatsbyjs.com/plugins/gatsby-source-graphql/#performance-tuning
Related Issue
#2160