First pass at adding social headers #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirshko
reviewed
May 1, 2019
docs/.vuepress/config.js
Outdated
| ['link', {rel: 'icon', type: 'image/png', href: 'favicon.png'}], | ||
| ['meta', { name: 'twitter:site', content: '@Ethereum' }], | ||
| ['meta', { name: 'twitter:creator', content: '@Ethereum' }], | ||
| ['meta', { property: 'og:type', content: 'article' }], |
There was a problem hiding this comment.
this should be set to "website" not "article"
alancwoo
approved these changes
May 1, 2019
|
Thanks @bmann ! I imagine down the road if we want more heavy SEO we could go with something like https://github.com/nuxt/vue-meta which would work well with vuepress as well! |
|
@alancwoo I found a vuepress specific one https://github.com/lorisleiva/vuepress-plugin-seo Likely each page / section needs proper metadata, which looks like it can be added in Markdown front matter. I’ll come back to this later and experiment. |
TylerAPfledderer
referenced
this pull request
in TylerAPfledderer/ethereum-org-website
Oct 27, 2023
feat: Breadcrumbs & get last update date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6
Adds basic OGP / Twitter metadata. Uses the image on the front page, which maybe doesn't read the best.
Probably should install this plugin and configure defaults https://github.com/lorisleiva/vuepress-plugin-seo