Skip to content

fix(10years): remove unwanted shadow from tabs list#18270

Merged
wackerow merged 5 commits into
devfrom
fix/10years-tab-shadow
May 26, 2026
Merged

fix(10years): remove unwanted shadow from tabs list#18270
wackerow merged 5 commits into
devfrom
fix/10years-tab-shadow

Conversation

@nloureiro
Copy link
Copy Markdown
Contributor

Summary

  • Adds shadow-none to the TabsList on the /10years page to override the default shadow / md:shadow-lg classes defined in the base tabs.tsx component

Related

Closes #18269

@netlify
Copy link
Copy Markdown

netlify Bot commented May 25, 2026

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 5d85ccf
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/6a15cd9fdfd12300083f1477
😎 Deploy Preview https://deploy-preview-18270.ethereum.it
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 66 (🟢 up 1 from production)
Accessibility: 96 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (🔴 down 1 from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nloureiro nloureiro self-assigned this May 25, 2026
@nloureiro nloureiro marked this pull request as draft May 25, 2026 11:07
nloureiro added 3 commits May 25, 2026 12:08
shadow-none alone wasn't enough — the base component also has
md:shadow-lg (overrides shadow-none at desktop), md:border (visible
box border), and !p-0.5 (!important padding). Add md:shadow-none,
md:border-0, and !p-0 to suppress all three.
The original className was overriding rounded-none + border-b + no-shadow
which broke the default card look while leaving the shadow active, causing
the "weird shadow" on a flat-edged box. Revert to default styles and only
override what's needed: full width, no wrap, and horizontal scroll.
Removing w-full/max-w-full so the tab list is only as wide
as its content, matching the default TabsList behaviour.
@nloureiro nloureiro marked this pull request as ready for review May 25, 2026 17:40
@wackerow wackerow merged commit fc5b6ec into dev May 26, 2026
14 of 15 checks passed
@wackerow wackerow deleted the fix/10years-tab-shadow branch May 26, 2026 16:43
@pettinarip pettinarip mentioned this pull request May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug report

2 participants