fix(codeblock): actually switch shiki theme to vitesse#18263
Merged
Conversation
PR #18195 updated component styles and CSS but missed the THEMES constant in src/lib/shiki.ts, so highlighted output still rendered with one-light / one-dark-pro instead of the vitesse pair promised in the PR description.
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
wackerow
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #18195. That PR was titled "switch theme to vitesse" and its description listed `vitesse-light` / `vitesse-dark` as the new themes, but the actual theme constants in `src/lib/shiki.ts` were never updated — only `CodeblockClient.tsx`, `index.tsx` and `codeblock.css` were touched. As a result, the deployed code blocks (verified on staging for the v11.7.0 deploy) still render with `one-light` / `one-dark-pro`.
const THEMES = { - light: \"one-light\", - dark: \"one-dark-pro\", + light: \"vitesse-light\", + dark: \"vitesse-dark\", } as const satisfies Record<string, BundledTheme>Both `vitesse-light` and `vitesse-dark` are valid `BundledTheme` values in shiki — no new dependency needed. The codeblock CSS already drives token colors through shiki's emitted `--shiki-light` / `--shiki-dark` CSS variables, so this single source change is enough.
How it was caught
Surfaced during the `/review-release` browser check on the v11.7.0 deploy PR (#18258). Snapshot of a `.shiki` element on staging showed:
Test plan