fix: stop versioning next-env.d.ts and generate it for type-check#18238
Closed
pettinarip wants to merge 1 commit into
Closed
fix: stop versioning next-env.d.ts and generate it for type-check#18238pettinarip wants to merge 1 commit into
pettinarip wants to merge 1 commit into
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
next-env.d.tshas been showing up as a modified file on everynext dev/next buildsince PR #18139 started tracking it. Two compounding causes:.prettierrchassemi: false, so the trailing semicolon Next.js writes on theimport "./.next/types/routes.d.ts";line got stripped. Next then sees a mismatch and rewrites it.next devuses.next/devasdistDir,next builduses.next. So the two modes write different paths (./.next/dev/types/routes.d.ts;vs./.next/types/routes.d.ts;). No single committed content can satisfy both. This is tracked upstream in vercel/next.js#85738.The official Next.js guidance is clear:
This PR follows that guidance:
next-env.d.tsto.gitignore(reverts the line removal in ci: consolidate workflows into ci.yml #18139).pnpm type-checkfromtsc --noEmittonext typegen && tsc --noEmit.next typegenships in Next 15.5+ and generatesnext-env.d.ts+.next/types/{routes,validator,cache-life}.d.tsin ~600ms — no full build needed, and as a bonus the CI type-check now actually validates the typed-routes layer (it didn't before, because.next/types/didn't exist in CI).Test plan
git statusstays clean acrosspnpm devandpnpm buildlocallytype-checkjob passes.next/) →pnpm type-checkworks end-to-endReferences