fix(ui): apply consistent my-8 to all markdown Alert usage#18235
Merged
Conversation
- Remove custom margin overrides within markdown usage of `Alert` component - Apply minimal 2rem top and bottom margins broadly to the `Alert` component for all markdown usage via `MdComponents/index.tsx` (additional margins from components above or below will automatically collapse and not add together)
wackerow
added
the
design system
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Updates [svg] to [svg:not(.lucide-external-link)] for SVG coloring in alert variants - Avoids re-coloring the external link arrow within Alert component Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
pettinarip
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Alertcomponent for all markdown usage viaMdComponents/index.tsx(additional margins from components above or below will automatically collapse and not add together)Alertcomponent:not(.lucide-external-link)onsvgselector to avoid re-coloring external link arrow icon within Alert componentRelated Issue
design system