chore(design-system): callout/banner family Storybook stories (PR 4 of #18191)#18203
Merged
Conversation
PR 4 of #18191, the final bundle. Adds Storybook stories for the five components slated for absorption into the unified Callout per #18133. Storying them before the consolidation gives that work a visual reference for the per-variant differences. Stories will be short-lived but earn their keep during the migration. Components covered: Callout (client thunk), CalloutBanner (server, page-staking namespace), CalloutSSR (server, plain strings), Banners/BannerNotification, and TranslationBanner. All five migrated from loose .tsx into Foo/index.tsx so the story files can live alongside. Adds page-staking to the storybook-next-intl namespace list so CalloutBanner can resolve its default-namespace keys. TranslationBanner has runtime visibility gates (non-English locale, DNT pathname, no prior dismissal); the meta documents the conditions needed to see it render in storybook. Each story uses the Components / Callouts / <Name> title pattern and opts out of Chromatic snapshots at the meta level per the #18121 convention. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pettinarip
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 4 of #18191, the final bundle. Adds Storybook stories for the five components slated for absorption into the unified
Calloutper #18133. Storying them before the consolidation gives that work a visual reference for the per-variant differences. Stories will be short-lived but earn their keep during the migration.Components covered (all migrated from loose
Foo.tsxtoFoo/index.tsx):Callout(client thunk) -- resolvestitleKey/descriptionKeyagainstcommonand forwards toCalloutSSRCalloutBanner(server) -- horizontal banner; default namespacepage-stakingCalloutSSR(server) -- accepts plaintitle/descriptionstrings, no key resolutionBanners/BannerNotification-- full-width primary-action bar gated byshouldShowTranslationBanner(client) -- dismissible toast gated by locale, pathname, and localStorage stateStorybook config tweak
Adds
page-stakingto thensarray in.storybook/next-intl.tssoCalloutBannercan resolve its default-namespace translation keys. One-line addition.Known limitations
TranslationBannerhas three runtime gates (non-default locale, DNT pathname, no prior dismissal). The meta description documents the conditions needed to see it render. In a default English Storybook session the stories rendernull-- this is intentional behavior, not a bug. The visual reference for the consolidation will still be accessible by reading the component source plus the meta docs.Coordination
Confirmed #18133 is open with no PRs linked, so PR 4 lands first as the issue intended. Once landed, the consolidation work has these stories as visual reference for what to preserve in the unified component.
Related to #18191. Does not close the issue.
Test plan
pnpm storybook-- five new entries appear underComponents / Callouts / *and render without console errors (TranslationBanner may render null per documented gates)CalloutBannerDefault story shows the realpage-staking-join-communitytitle / description, confirming the namespace addition worked@/components/Fooimports after the migrationsClaude (Opus 4.7) co-authored these changes.