Skip to content

chore(design-system): card-family Storybook stories (PR 1 of #18191)#18199

Merged
pettinarip merged 1 commit into
devfrom
chore/storybook-feature-cards
May 19, 2026
Merged

chore(design-system): card-family Storybook stories (PR 1 of #18191)#18199
pettinarip merged 1 commit into
devfrom
chore/storybook-feature-cards

Conversation

@myelinated-wackerow
Copy link
Copy Markdown
Collaborator

Summary

PR 1 of #18191. Adds Storybook stories for six reusable card-shaped feature components and migrates the loose Foo.tsx siblings into Foo/index.tsx so the story files can live alongside them.

Components covered:

  • ActionCard (migrated)
  • CommentCard
  • GhostCard (migrated)
  • HighlightCard (storied as the composition family: IconBox, HighlightStack, HighlightCard, HighlightCardContent)
  • HorizontalCard (migrated)
  • SubpageCard (migrated)

Each story uses the Components / Cards / <Name> title pattern, has Default plus variant/composite stories, and opts out of Chromatic snapshots at the meta level per the convention established in #18121. Snapshots can be re-enabled per-story once we decide which views warrant regression coverage.

Related to #18191. Does not close the issue.

Test plan

  • pnpm storybook -- the six new entries appear under Components / Cards / * and render without console errors
  • a11y addon panel is clean on each story
  • Consumer pages (community, what-is-the-ethereum-network, stablecoins, gas, what-is-ethereum, developers/tools, etc.) still resolve their @/components/Foo imports after the migrations

Claude (Opus 4.7) co-authored these changes.

PR 1 of #18191. Adds Storybook stories for six reusable card-shaped feature components and migrates the four loose .tsx files into Foo/index.tsx so the story files can live alongside them.

Components covered: ActionCard, CommentCard, GhostCard, HighlightCard, HorizontalCard, SubpageCard. Each story uses the new Components / Cards / <Name> title pattern, has Default + variant + composite stories, and opts out of Chromatic snapshots at the meta level per the team convention established in #18121.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented May 15, 2026

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit b25edf5
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/6a071207b9da64000990af83
😎 Deploy Preview https://deploy-preview-18199.ethereum.it
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 70 (🟢 up 5 from production)
Accessibility: 96 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (🔴 down 1 from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@pettinarip pettinarip merged commit b5fa2d3 into dev May 19, 2026
16 checks passed
@pettinarip pettinarip deleted the chore/storybook-feature-cards branch May 19, 2026 15:09
@claude claude Bot mentioned this pull request May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants