refactor: centralize site title suffix in metadata#18196
Merged
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
content 🖋️
kafeelraza
force-pushed
the
fix-centralized-site-title
branch
from
aa4030a to
d2398b5
Compare
wackerow
requested changes
May 15, 2026
Member
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
Thanks @kafeelraza! Looks great! Nice and clean
Left one inline code suggestion, but also, src/intl/en/page-layer-2-learn.json line 2 also has the | ethereum.org appendage... would you mind patching that one as well? Then I think this is good to go
wackerow
approved these changes
May 18, 2026
Member
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the help @kafeelraza!
Member
|
@all-contributors please add @kafeelraza for code |
Contributor
|
I've put up a pull request to add @kafeelraza! 🎉 |
Contributor
Author
|
Thanks @wackerow and everyone for the review and guidance. Happy to contribute to ethereum.org |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR centralizes the
ethereum.orgsite title suffix handling ingetMetadatainstead of hardcoding it in translation strings.Changes
SITE_TITLEconstant insrc/lib/constants.tst("site-title")usages withSITE_TITLEmetadata.ts| ethereum.orgsuffixes from EN intl filesethereum.orgNotes
ENOENTmissing content file).Related issue