fix(qa): filter past hackathons and add site name to page titles#18180
Conversation
- app/[locale]/developers/utils.tsx: getHackathons() now applies a runtime date guard (endTime/startTime >= now) so stale cached data never surfaces already-finished events in the hackathon section. - src/intl/en/page-developers-index.json: add '| ethereum.org' suffix to meta title for /developers/ - src/intl/en/page-get-eth.json: add '| ethereum.org' suffix to meta title for /get-eth/ - src/intl/en/page-layer-2.json: add '| ethereum.org' suffix to meta title for /layer-2/ Identified via weekly QA automated review (2026-05-11).
nloureiro
requested review from
minimalsm,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
content 🖋️
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "page-developer-meta-title": "Ethereum Developer Resources", | |||
| "page-developer-meta-title": "Ethereum Developer Resources | ethereum.org", | |||
There was a problem hiding this comment.
@nloureiro I see we're using this pattern inconsistently -- I think a cleaner solution would be to bake this into the src/lib/utils/metadata.ts getMetadata helper function. We have siteTitle in there which displays ethereum.org, which we could automatically append to the end of the titles on all pages.
- Avoids repeating ourselves
- Avoids unnecessary intl complications
- Avoids inconsistency for any new pages
The homepage uses "Ethereum - The complete guide from Ethereum.org" which 1- we should lowercase "ethereum.org", and 2- we can simply opt that page out of automatically appending | ethereum.org to the end since it'd be redundant.
If you're okay with that, perhaps we revert these from this PR, merge in the hackathon changes, and we can set up an issue to fix up the og:title metadata in a separate PR.
There was a problem hiding this comment.
Issue #18185 posted with refactor summary -- No harm in just pulling these in and a follow-up task can address more completely.
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "page-developer-meta-title": "Ethereum Developer Resources", | |||
| "page-developer-meta-title": "Ethereum Developer Resources | ethereum.org", | |||
There was a problem hiding this comment.
Issue #18185 posted with refactor summary -- No harm in just pulling these in and a follow-up task can address more completely.
2 participants
Summary
Fixes three issues found in the weekly automated QA review (2026-05-11).
Changes
getHackathons()now applies a runtime date guard so events past their end date are never shown, even if the cached event data is stale.Not included
The "roadmap for 2025" heading on `/what-is-ethereum/` is already fixed on `dev` (says 2026) — it just hasn't shipped to production yet.