Fix horizontal page overflow from EdgeScrollContainer#18167
Merged
Conversation
The inner overflow-x:auto scroll area was leaking into the document's scroll width, causing horizontal page scroll on /community/events. Add `relative overflow-x-clip` on the wrapper to contain it; `relative` is required for `clip` to work in Chromium. Fixes #17777
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Tests that pages using EdgeScrollContainer don't leak horizontal overflow to the document scroll area. Runs against /community/events/ (the page that triggered #17777) and three other pages that use the component. Asserts both: real scroll attempt (`scrollBy` → scrollX stays 0) and layout measurement (`scrollWidth <= clientWidth`). The two catch different classes of regression.
wackerow
approved these changes
May 11, 2026
Member
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
Thanks @pettinarip, pulling in!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/community/eventshad ~2300px of horizontal page overflow on mobile (and other viewports).overflow-x: autoflex scroll area insideEdgeScrollContainerwas leaking into the document's scroll width despite ancestors havingoverflow: visible. The 8-card hubs instance had enough internal scroll width to make the leak user-visible; smaller instances on/developers/tools,/developers, and/community/events/conferencesstayed below the threshold but were similarly affected.relative overflow-x-clipon theEdgeScrollContainerouter wrapper.position: relativeis required —overflow-x: clipalone does not contain the leak in Chromium (it preventswindow.scrollTofrom moving but real wheel/touch scrolling still produces overflow).Test plan
/community/eventsno longer scrolls horizontallydocument.documentElement.scrollWidth === clientWidthafter loadoverflow-y)/developers/tools,/developers,/community/events/conferences