a11y: ProductTable filter sidebar semantics#18153
Merged
Merged
Conversation
Wraps shared Filter groups in <fieldset> via shadcn FieldSet with sr-only legends, and replaces the SwitchFilterInput sibling-<p> label with a real <label> via FieldLabel + FieldDescription. Adds optional FilterItem.optionsLegend so the nested platform sub-groups (mobile/desktop/browser) on /wallets/find-wallet are labeled too. Visual layout unchanged. Installs the shadcn field component family (field, label, separator) and tunes defaults to match project tokens (text-body-medium, text-error). Drops the dead labelVariants cva and the unneeded "use client" on separator. English-only translation strings added; intl-pipeline will propagate the rest. Refs #18114 (PR 1 of 2). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
myelinated-wackerow
requested review from
minimalsm,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
content 🖋️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #18114 (PR 1 of 2). Sidebar accessibility/semantic-HTML pass for the shared ProductTable filter UI -- benefits both /wallets/find-wallet and /layer-2/networks.
<fieldset>with sr-only<legend>via the shadcn FieldSet primitive, at both the outer (Device, Network support, etc.) and inner (Mobile/Desktop/Browser platforms) levels.aria-describedby, replacing sibling<p>tags.Persona-card refactor on /wallets/find-wallet ships in a follow-up PR.
Test plan
<fieldset>with sr-only<legend>matching the visible group title.<fieldset>renders with sr-only<legend>"Mobile platforms" / "Desktop platforms" / "Browser engines".Generated by Claude Opus 4.7