Skip to content

ci: validate consolidated workflows (extended path)#18140

Closed
pettinarip wants to merge 3 commits into
test/ci-validationfrom
ci/consolidate-workflows
Closed

ci: validate consolidated workflows (extended path)#18140
pettinarip wants to merge 3 commits into
test/ci-validationfrom
ci/consolidate-workflows

Conversation

@pettinarip
Copy link
Copy Markdown
Member

Description

Validation-only PR. Targets test/ci-validation (a throwaway branch off dev) so the workflow's test/** gate triggers all extended jobs:

  • build (mock-data multi-locale)
  • e2e-tests (Playwright)
  • lighthouse (audit + sticky comment)
  • visual-tests (Storybook → Chromatic)
  • page-visual-tests (Playwright → Chromatic Pages)

Companion to #18139 (which only exercises lint + unit-tests against dev).

What to verify in the run

  • e2e: server start step runs before Playwright install
  • Lighthouse: sticky comment posts (validates marocchino/sticky-pull-request-comment@v2 + actions/github-script@v7)
  • Storybook Chromatic: chromaui/action@v16 accepts existing options
  • Page-visual: passes without USE_MOCK_DATA / IS_VISUAL_TEST runtime env
  • Concurrency cancel works on a second push

Do not merge. Close after validation; delete test/ci-validation.

@github-actions github-actions Bot added dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project labels May 6, 2026
@pettinarip pettinarip force-pushed the ci/consolidate-workflows branch from 3f14e6c to b0ba202 Compare May 6, 2026 17:42
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Page Performance Accessibility Best practices SEO PWA

Lighthouse scores are calculated based on the latest audit results

@pettinarip pettinarip force-pushed the ci/consolidate-workflows branch 2 times, most recently from 46b2c92 to 7062c1e Compare May 6, 2026 20:48
fix: wallet logo span, title alignment
@netlify
Copy link
Copy Markdown

netlify Bot commented May 7, 2026

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit c0503c3
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/69fc9c6e2367260008bbad42
😎 Deploy Preview https://deploy-preview-18140.ethereum.it
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 70 (🟢 up 5 from production)
Accessibility: 96 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (🔴 down 1 from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@pettinarip pettinarip force-pushed the ci/consolidate-workflows branch from 9e5b513 to efc481a Compare May 7, 2026 14:04
@pettinarip pettinarip force-pushed the ci/consolidate-workflows branch from efc481a to c0503c3 Compare May 7, 2026 14:06
@pettinarip
Copy link
Copy Markdown
Member Author

Validation PR for the workflow consolidation in #18139. Served its purpose — closing now that #18139 is verified.

@pettinarip pettinarip closed this May 7, 2026
@github-actions github-actions Bot added the abandoned This has been abandoned or will not be implemented label May 7, 2026
@wackerow wackerow deleted the ci/consolidate-workflows branch May 12, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

abandoned This has been abandoned or will not be implemented dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants