Skip to content

refactor(skills): split performance into references#18119

Merged
wackerow merged 2 commits into
devfrom
refactor/perf-skill-split
May 11, 2026
Merged

refactor(skills): split performance into references#18119
wackerow merged 2 commits into
devfrom
refactor/perf-skill-split

Conversation

@pettinarip
Copy link
Copy Markdown
Member

@pettinarip pettinarip commented May 4, 2026

Summary

  • Split the monolithic performance skill into a knowledge skill with chunked references following the Agent Skills progressive-disclosure pattern.
  • Top-level SKILL.md is a thin index; rule content lives in references/ (one file per topic: diagnose-table, edge-caching, bundle, build, rsc, inp, images, data-fetching, anti-patterns, shipped, external-overrides).
  • Marked user-invocable: false so the model can auto-load the skill on perf topics but it stays out of the / autocomplete menu.
  • All knowledge consolidated inside the skill — no pointers to repo docs or memory files.

Test plan

  • `npx skills-ref validate .claude/skills/performance` passes (only `user-invocable` flagged — documented Claude Code extension)
  • Claude Code skill listing includes `performance` description
  • `/performance` does not appear in Claude Code's slash autocomplete
  • Asking a perf question (e.g., "what's our rule on edge caching?") triggers the model to load `references/edge-caching.md`
  • `grep -r 'docs/' .claude/skills/performance/` returns nothing — knowledge is self-contained

@netlify
Copy link
Copy Markdown

netlify Bot commented May 4, 2026

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit e0cc48b
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/69f9e91b96ac800008ac8484
😎 Deploy Preview https://deploy-preview-18119.ethereum.it
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 68 (🟢 up 3 from production)
Accessibility: 96 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (🔴 down 1 from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@pettinarip pettinarip force-pushed the refactor/perf-skill-split branch from f46357b to 6501da7 Compare May 5, 2026 12:21
@pettinarip pettinarip force-pushed the refactor/perf-skill-split branch from 6501da7 to 6b4953c Compare May 5, 2026 12:24
@pettinarip pettinarip marked this pull request as ready for review May 5, 2026 14:38
Copy link
Copy Markdown
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ npx skills-ref validate .claude/skills/performance
Validation failed for .claude/skills/performance:
  - Unexpected fields in frontmatter: user-invocable. Only allowed-tools, compatibility, description, license, metadata, name are allowed.

Per test note in PR body, this looks correct -- only user-invocable being flagged.

Lgtm, thanks @pettinarip

---
name: performance
description: Performance patterns and anti-patterns for ethereum.org covering TTFB, LCP, INP, CLS, bundle size, build memory, and RSC payload. Use when diagnosing a perf regression or reviewing proposed code changes for perf landmines.
user-invocable: false
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Noting this does show up when you type the full /performance but anything less and it does not show the auto-complete -- should be find

@wackerow wackerow merged commit 69df51a into dev May 11, 2026
11 checks passed
@wackerow wackerow deleted the refactor/perf-skill-split branch May 11, 2026 15:36
@pettinarip pettinarip restored the refactor/perf-skill-split branch May 12, 2026 09:48
@pettinarip pettinarip mentioned this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants