Skip to content

fix: circular import; extract REFERENCE to own namespace#18093

Merged
wackerow merged 1 commit into
devfrom
fix-circular-import
Apr 30, 2026
Merged

fix: circular import; extract REFERENCE to own namespace#18093
wackerow merged 1 commit into
devfrom
fix-circular-import

Conversation

@myelinated-wackerow
Copy link
Copy Markdown
Collaborator

Description

  • Fixes circular import logic introduced in dc32e51
  • Moves REFERENCE constant to own namespace; updates imports

Alternatively could've re-exported, but this assigns the "@id" reference data to it's own namespace for clarity.

Related Issue

Before:

  • organizations.ts imports REFERENCE from constants.ts
  • organizations.ts exports KNOWN_ORGANIZATIONS, which uses REFERENCE
  • constants.ts declares REFERENCE, but imports KNOWN_ORGANIZATIONS

pnpm build passing locally

Note: image placeholder generated from build process and committed unintentionally, but will keep in as innocuous addition that we should have anyway

Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 30, 2026

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 8250db6
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/69f3c4fd8e7c2b0009cbc163
😎 Deploy Preview https://deploy-preview-18093.ethereum.it
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 71 (🟢 up 17 from production)
Accessibility: 96 (🟢 up 3 from production)
Best Practices: 100 (no change from production)
SEO: 98 (🔴 down 1 from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the tooling 🔧 Changes related to tooling of the project label Apr 30, 2026
@wackerow wackerow merged commit da4d69a into dev Apr 30, 2026
10 of 11 checks passed
@wackerow wackerow deleted the fix-circular-import branch April 30, 2026 21:09
@wackerow wackerow mentioned this pull request May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tooling 🔧 Changes related to tooling of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants