Skip to content

fix: remove excessive min-height gap in staking product cards#18079

Merged
wackerow merged 1 commit into
devfrom
fix/staking-product-card-gap
May 11, 2026
Merged

fix: remove excessive min-height gap in staking product cards#18079
wackerow merged 1 commit into
devfrom
fix/staking-product-card-gap

Conversation

@pettinarip
Copy link
Copy Markdown
Member

@pettinarip pettinarip commented Apr 30, 2026

Summary

  • The Chakra → Tailwind migration translated minHeight={75} directly to min-h-75, which resolves to ~300px (75 × 0.25rem) and reserved a large empty gap below the platform/UI badges in every staking product card
  • Grid layout already equalizes card heights across rows and mt-auto keeps the footer aligned, so no min-height is needed on the badges container
  • Affects all four staking product grids: /staking/solo/, /staking/saas/, /staking/pools/, and the keyGen grid

Test plan

  • Visit /staking/solo/ — cards no longer show a large empty gap between the platform/UI badges and the considerations list
  • Visit /staking/saas/ and /staking/pools/ — cards still align properly across rows
  • Spot-check a card with the most badges (Launchnodes, stakefish — 6 badges) — badges still wrap and lay out correctly

The Chakra→Tailwind migration translated `minHeight={75}` directly to
`min-h-75`, which resolves to ~300px (75 × 0.25rem) and reserved a large
empty gap below the platform/UI badges in every staking product card.
Grid layout already equalizes card heights and `mt-auto` keeps the
footer aligned, so no min-height is needed.
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 30, 2026

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 11e7a41
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/69f36cc81b4f6e00085cc4da
😎 Deploy Preview https://deploy-preview-18079.ethereum.it
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 70 (🟢 up 16 from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (🔴 down 1 from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@wackerow wackerow merged commit a17d370 into dev May 11, 2026
11 checks passed
@wackerow wackerow deleted the fix/staking-product-card-gap branch May 11, 2026 15:19
@pettinarip pettinarip mentioned this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants