fix(seo): ssr the network list on /layer-2/networks#18068
Merged
Conversation
Same pattern as /wallets/find-wallet (#18067, #17717): the page mounted Layer2NetworksTable through a `dynamic(..., { ssr: false })` wrapper, so Googlebot indexed only the loading skeleton — zero network names in the HTML. Drop the lazy wrapper and import directly. Add `"use client"` to `Layer2NetworksTable` since it needs hooks (`useTranslation`, `useNetworkFilters`) and is no longer crossing the boundary via `dynamic()`. Delete the now-unused `lazy.tsx` and `loading.tsx`. The shared `ProductTable` SSR fixes (`useSearchParams` → window.location, `MediaQuery` wrapper removal) already landed in #18067 and apply unchanged to this consumer.
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
wackerow
approved these changes
Apr 30, 2026
Member
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
Looks good! Thanks @pettinarip
Thought for future while reviewing, would be nice to have animation on the opening/closing action of these rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #18067. Same anti-SEO pattern:
Layer2NetworksTablewas mounted viadynamic(..., { ssr: false }), so the deployed HTML for/layer-2/networkscontains only a loading skeleton — zero network names indexed by bots.This PR drops the lazy wrapper and imports
Layer2NetworksTabledirectly. The sharedProductTableSSR-safety work (useSearchParams→window.location.search,MediaQueryremoval) from #18067 carries over to this consumer unchanged, so no further surgery is needed in shared code.Verification
Hydration smoke-checked in browser: 11
<tr>rows present, no console errors, expand/collapse + filters still work.Dependency
Stacked on top of #18067 — that PR contains the shared
ProductTablefixes this PR depends on. Merge order: #18067 first, then this.Test plan