fix(intl-pipeline): support directory paths in TARGET_PATH#18062
Merged
Conversation
Restores historical behavior: passing a directory (e.g. public/content/videos/) now expands to all .md files under it (or .json files under src/intl/en/) and translates each. Previously the pipeline tried readFileSync on the directory and threw EISDIR. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
myelinated-wackerow
requested review from
minimalsm,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
wackerow
approved these changes
Apr 28, 2026
Member
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
cc: @pettinarip pulling this patch in -- "directory" approach was lost in the migration (only comma separated files were working) -- this restores that functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores historical behavior: passing a directory as
target_path(e.g.public/content/videos/) now expands to all.mdfiles under it (or.jsonfiles undersrc/intl/en/) and translates each. Previously the pipeline triedreadFileSyncon the directory and threwEISDIR.Test plan
intl-pipeline.ymlwithtarget_path=public/content/videos/, single locale → expansion logged, all files translated.target_path(existing behavior) still works.Generated by Claude Opus 4.7