Skip to content

fix(deps): patch fast-xml-parser critical CVE (GHSA-m7jm-9gc2-mpf2)#18012

Merged
pettinarip merged 1 commit into
devfrom
security/fast-xml-parser-ghsa-m7jm-9gc2-mpf2
Apr 23, 2026
Merged

fix(deps): patch fast-xml-parser critical CVE (GHSA-m7jm-9gc2-mpf2)#18012
pettinarip merged 1 commit into
devfrom
security/fast-xml-parser-ghsa-m7jm-9gc2-mpf2

Conversation

@myelinated-wackerow
Copy link
Copy Markdown
Collaborator

@myelinated-wackerow myelinated-wackerow commented Apr 21, 2026

Summary

Resolves Dependabot alert #240GHSA-m7jm-9gc2-mpf2 / CVE-2026-25896 (CVSS 9.3, critical) in fast-xml-parser.

Lockfile-only change via pnpm update fast-xml-parser and pnpm update @aws-sdk/client-s3. Resolved version moves from 5.3.4 → 5.5.8, which is above the 5.3.5 patch floor.

Why this fix

  • The vulnerability: a . in a DOCTYPE entity name is treated as a regex wildcard during entity replacement, allowing an
    attacker to shadow built-in XML entities (<, >, &, ", ') with arbitrary values. This bypasses entity
    encoding and leads to XSS when parsed output is rendered. Patched upstream in 5.3.5.
  • How it reaches us: fast-xml-parser is a pure transitive dependency — the only consumer chain is @aws-sdk/xml-builder via
    @aws-sdk/client-s3 and @aws-sdk/credential-provider-node, and it resolves to a single version. We do not import it directly
    in app code.
  • Why no pnpm.overrides entry: @aws-sdk/xml-builder@3.972.4 declares fast-xml-parser: ^5.0.0, so normal resolution picks
    5.5.8 without needing a permanent override. Keeps the diff minimal — lockfile only, no package.json change.

Breaking-change risk

Low.

  • fast-xml-parser 5.3.4 → 5.5.8 is a minor bump within the same major; no documented breaking changes in that window.
  • The library is only exercised inside AWS SDK internals (S3 XML response parsing). Our only AWS usage is the data layer's
    S3-compatible storage (s3-dcl1.ethquokkaops.io) serving app screenshots for /dapps.
  • No new peer-dependency conflicts were introduced.

Test plan

  • CI passes (lint, typecheck, build)
  • Netlify preview deploy succeeds
  • /dapps and app listing pages load images correctly (verifies S3 data-layer read path still works)
  • Dependabot alert #240 closes after merge

Generated by Claude (Opus 4.7)

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 21, 2026

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 5146757
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/69e957bb9f1afc0008169321
😎 Deploy Preview https://deploy-preview-18012.ethereum.it
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 59 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (🔴 down 1 from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the dependencies 📦 Changes related to project dependencies label Apr 21, 2026
Copy link
Copy Markdown
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myelinated-wackerow quick question before merge: do we need the override? @aws-sdk/xml-builder@3.972.4 already declares fast-xml-parser: ^5.0.0, so pnpm update fast-xml-parser (or pnpm update @aws-sdk/client-s3) should resolve to 5.7.1 through normal resolution — just a lockfile change, no permanent package.json entry.

@wackerow wackerow force-pushed the security/fast-xml-parser-ghsa-m7jm-9gc2-mpf2 branch from 3415865 to 5146757 Compare April 22, 2026 23:20
@wackerow
Copy link
Copy Markdown
Member

@pettinarip yeah good call, cleaner -- updated PR and description

@pettinarip pettinarip merged commit 2e8a4c3 into dev Apr 23, 2026
10 checks passed
@pettinarip pettinarip deleted the security/fast-xml-parser-ghsa-m7jm-9gc2-mpf2 branch April 23, 2026 15:43
@wackerow wackerow mentioned this pull request Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies 📦 Changes related to project dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants