fix(deps): patch fast-xml-parser critical CVE (GHSA-m7jm-9gc2-mpf2)#18012
Merged
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pettinarip
reviewed
Apr 22, 2026
Member
pettinarip
left a comment
There was a problem hiding this comment.
@myelinated-wackerow quick question before merge: do we need the override? @aws-sdk/xml-builder@3.972.4 already declares fast-xml-parser: ^5.0.0, so pnpm update fast-xml-parser (or pnpm update @aws-sdk/client-s3) should resolve to 5.7.1 through normal resolution — just a lockfile change, no permanent package.json entry.
Bump fast-xml-parser to >=5.3.5 to resolve GHSA-m7jm-9gc2-mpf2 / CVE-2026-25896 (critical).
3415865 to
5146757
Compare
Member
|
@pettinarip yeah good call, cleaner -- updated PR and description |
pettinarip
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Resolves Dependabot alert #240 — GHSA-m7jm-9gc2-mpf2 / CVE-2026-25896 (CVSS 9.3, critical) in
fast-xml-parser.Lockfile-only change via
pnpm update fast-xml-parserandpnpm update @aws-sdk/client-s3. Resolved version moves from 5.3.4 → 5.5.8, which is above the5.3.5patch floor.Why this fix
.in a DOCTYPE entity name is treated as a regex wildcard during entity replacement, allowing anattacker to shadow built-in XML entities (
<,>,&,",') with arbitrary values. This bypasses entityencoding and leads to XSS when parsed output is rendered. Patched upstream in 5.3.5.
fast-xml-parseris a pure transitive dependency — the only consumer chain is@aws-sdk/xml-buildervia@aws-sdk/client-s3and@aws-sdk/credential-provider-node, and it resolves to a single version. We do not import it directlyin app code.
@aws-sdk/xml-builder@3.972.4declaresfast-xml-parser: ^5.0.0, so normal resolution picks5.5.8without needing a permanent override. Keeps the diff minimal — lockfile only, no package.json change.Breaking-change risk
Low.
fast-xml-parser5.3.4 → 5.5.8 is a minor bump within the same major; no documented breaking changes in that window.S3-compatible storage (
s3-dcl1.ethquokkaops.io) serving app screenshots for/dapps.Test plan
/dappsand app listing pages load images correctly (verifies S3 data-layer read path still works)Generated by Claude (Opus 4.7)