perf: lazy-load layer-2 networks table#18007
Merged
Merged
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pettinarip
commented
Apr 21, 2026
| }).format(row.original.txCosts || 0)} | ||
| </> | ||
| ) : ( | ||
| <p>-</p> |
Member
Author
There was a problem hiding this comment.
this was causing a hydration issue (p inside a p)
pettinarip
commented
Apr 21, 2026
| <MainArticle className="relative flex flex-col"> | ||
| <ContentHero {...heroProps} /> | ||
|
|
||
| <Layer2NetworksTable |
Member
Author
There was a problem hiding this comment.
move all into the server-page level component, except form Layer2NetworksTable that is lazy loaded. This way we can have the h1 and content server rendered
wackerow
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Layer2NetworksTableon/layer-2/networksusing the project's establishedlazy.tsx+loading.tsxconvention (same pattern asFindWalletProductTable)NetworkMaturityremain server-rendered so SEO is unaffectedProductTable→MediaQueryon first paint (server renders without the desktop filter column, client was trying to mount it)_components/networks.tsxwrapper and the now-pointless<Suspense>around the client treeExtendedRollupcast onmainnetDataat the page boundary — the old untyped wrapper had been masking thatethereumNetworkDatadoesn't fully satisfy the type (runtime behavior unchanged)Test plan
/layer-2/networkson desktop — no hydration error in console, skeleton flashes briefly before the table mountsdevpnpm buildpasses, route First Load JS for/layer-2/networksdrops vsdevPreview link
https://deploy-preview-18007.ethereum.it/layer-2/networks