[hot-fix] patch(intl): sim component namespace to /wallets#18000
Merged
Conversation
Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
myelinated-wackerow
requested review from
minimalsm,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pettinarip
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes broken translation keys (
sim-ca-title,sim-sr-title,sim-cw-title, etc.) rendering on the/wallets/page where the Wallet Simulator is embedded.Root cause
app/[locale]/wallets/page.tsxusesgetRequiredNamespacesForPage("/wallets")to pick the messages passed intoI18nProvider. That helper returnedpage-wallets(pluscommon, glossary, quizzes) but notcomponent-wallet-simulator, so the simulator's strings were missing from the client bundle and fell back to raw keys.The homepage was unaffected because
app/[locale]/page.tsxexplicitly pickscomponent-wallet-simulatoralongside page-index.Fix
Added
"/wallets/": ["component-wallet-simulator"]toEXACT_PATH_ADDITIONAL_NAMESPACESinsrc/lib/utils/translations.tsso the namespace is included wherever getRequiredNamespacesForPage is called for that route.Testing
/wallets/(English) and confirm the simulator renders translated strings rather than raw keys.