fix(scripts): route prepare-release logs to stderr#17986
Merged
Conversation
log_info/warn/error/dry now write to stderr, and cmd_version redirects pnpm/git push output to stderr. This keeps `VERSION=$(... version minor)` clean so the captured value is just `11.4.0`, not log noise. Previously that noise propagated into the publish step and produced a double-v tag (vv11.4.0).
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
wackerow
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
log_*functions insrc/scripts/prepare-release.shnow write to stderrcmd_versionredirectspnpm versionandgit pushoutput to stderr tooVERSION=$(./src/scripts/prepare-release.sh version minor)cleanly captures just11.4.0— no log noise contaminating the valueWhy
During the v11.4.0 release today,
VERSIONin the/prepare-releaseflow captured log output alongside the bare version. When passed topublish "$VERSION", the script prependedvand produced the tagvv11.4.0. The release had to be deleted and recreated manually viagh release create v11.4.0.With this fix, only
echo "$NEW_VERSION"hits stdout fromcmd_version, so command substitution captures the value the downstream commands expect.Test plan
./src/scripts/prepare-release.sh --dry-run version patchand confirm stdout contains only the bare version string (X.Y.Z)./src/scripts/prepare-release.sh --dry-run preflightand confirm logs still render with colors in the terminalpublishstep produces a single-vtag