Skip to content

feat: videos page#17970

Merged
pettinarip merged 2 commits into
devfrom
videos-refactor-v2
Apr 15, 2026
Merged

feat: videos page#17970
pettinarip merged 2 commits into
devfrom
videos-refactor-v2

Conversation

@wackerow
Copy link
Copy Markdown
Member

@wackerow wackerow commented Apr 13, 2026

Summary

Adds /videos gallery with individual /videos/[slug] pages for viewing, containing video transcripts

Extension of original work in:

Data layer

  • Moved all video metadata from videos.json into markdown frontmatter (index.md)
  • Renamed transcript.md to index.md for each video
  • Rewrote data layer to read from filesystem instead of JSON
  • Added VideoFrontmatter type, replaced old Video/VideoMeta/VideoWithMeta types
  • Deleted videos.json and videoTranscripts.ts (merged into videos.ts)
  • Added breadcrumb frontmatter to all 42 videos
  • Used shared stripMarkdown instead of duplicate stripMdx

Components and organization

  • Moved page-scoped components out of src/components/ into app/[locale]/videos/_components/
  • Inlined transcript accordion and markdown rendering directly into page.tsx
  • Moved VIDEO_CATEGORIES to colocated constants.ts, getVideosByCategory to utils.ts
  • Updated VideoWatch shared component for new data layer
  • Cleaned up unused i18n keys
  • Removed PR-added unit and e2e tests

SEO preserved

  • JSON-LD VideoObject schema on every video detail page
  • Transcript text stays in DOM when accordion is closed via forceMount
  • generateStaticParams pre-renders all video pages at build time
  • Per-video generateMetadata for title and description meta tags
  • Breadcrumbs with translatable labels
  • Sitemap inclusion for video pages
  • Semantic HTML structure

Preview links

Schema Markup Validator


Note: Recovers PR #17870 which was reverted after being merged prior to passing necessary checks.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 13, 2026

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 7fae1ce
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/69de7098d74094000897c05d
😎 Deploy Preview https://deploy-preview-17970.ethereum.it
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 54 (🔴 down 5 from production)
Accessibility: 94 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (🔴 down 1 from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added config ⚙️ Changes to configuration files content 🖋️ This involves copy additions or edits documentation 📖 Change or add documentation tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Apr 13, 2026
@pettinarip pettinarip merged commit c4da302 into dev Apr 15, 2026
11 checks passed
@pettinarip pettinarip deleted the videos-refactor-v2 branch April 15, 2026 15:09
@pettinarip pettinarip mentioned this pull request Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config ⚙️ Changes to configuration files content 🖋️ This involves copy additions or edits documentation 📖 Change or add documentation tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants