Skip to content

refactor: descriptive thumbnail naming #17948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pettinarip merged 2 commits into from
Apr 23, 2026
Merged

refactor: descriptive thumbnail naming #17948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a905af
refactor: descriptive thumbnail naming
wackerow Apr 8, 2026
bdc3c73
Merge branch 'dev' into fallback-placeholder
wackerow Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/[locale]/developers/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ import scaffoldDebugScreenshot from "@/public/images/developers/scaffold-debug-s
import stackExchangeScreenshot from "@/public/images/developers/stack-exchange-screenshot.png"
import tutorialTagsBanner from "@/public/images/developers/tutorial-tags-banner.png"
import dogeImage from "@/public/images/doge-computer.png"
import EventFallback from "@/public/images/events/event-placeholder.png"
import fallbackThumbnail from "@/public/images/eth-glyph-thumbnail.png"
import heroImage from "@/public/images/heroes/developers-hub-hero.png"
const H3 = (props: ChildOnlyProp) => <h3 className="mt-10 mb-8" {...props} />

Expand Down Expand Up @@ -604,7 +604,7 @@ const DevelopersPage = async (props: { params: Promise<PageParams> }) => {
{bannerImage ? (
<CardImage src={bannerImage} />
) : (
<Image src={EventFallback} alt="" sizes="276px" />
<Image src={fallbackThumbnail} alt="" sizes="276px" />
)}
</CardBanner>
<CardContent>
Expand Down
0 public/images/events/event-placeholder.png → public/images/eth-glyph-thumbnail.png
View file
Open in desktop
File renamed without changes
6 changes: 3 additions & 3 deletions src/components/Image/CardImage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import { ComponentProps, forwardRef } from "react"

import EventFallback from "@/public/images/events/event-placeholder.png"
import fallbackThumbnail from "@/public/images/eth-glyph-thumbnail.png"

type CardImageProps = ComponentProps<"img">

Expand All @@ -11,12 +11,12 @@ const CardImage = forwardRef<HTMLImageElement, CardImageProps>(
// eslint-disable-next-line @next/next/no-img-element
<img
ref={ref}
src={src || EventFallback.src}
src={src || fallbackThumbnail.src}
alt=""
loading="lazy"
onError={(e) => {
e.currentTarget.onerror = null
e.currentTarget.src = EventFallback.src
e.currentTarget.src = fallbackThumbnail.src
}}
referrerPolicy="no-referrer"
className={className}
Expand Down
Loading